Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies + Native gems: sqlite3-ruby, nokogiri, jaro_winkler #20

Merged
merged 30 commits into from
Apr 3, 2020

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Mar 26, 2020

@jmarrec
Copy link
Collaborator Author

jmarrec commented Mar 26, 2020

at 0b019ba, linux doesn't have sqlite3-dev installed, mac reports this:

Using sqlite3 1.3.13.20180326210955 from https://github.com/jmarrec/sqlite3-ruby.git (at MSVC_support@69bbc8f)
Build static extension: ext/sqlite3/extconf.rb
NameError: undefined local variable or method `dest_path' for
#<StaticExtensionPlugin:0x00007fab4dd210e0>
An error occurred while installing sqlite3 (1.3.13.20180326210955), and Bundler
cannot continue.

replaying all three with cbci_jenkins@openstudio_gems_conan

@tijcolem
Copy link
Collaborator

I see the same error on windows regarding NameError: undefined local variable or method 'dest_path' for

The 'dest_path' var is set in lib/rubygems_plugin.rb which is what creates the statically compiled ruby gems during the rake make_package task.

@tijcolem
Copy link
Collaborator

Looks like a simple fix. Just need to change this to tmp_dest
https://github.com/NREL/openstudio-gems/blob/develop/lib/rubygems_plugin.rb#L99

@tijcolem
Copy link
Collaborator

Okay, added that fix in for dest_path var and also added in nokogiri to this branch,

This should now have #18 + sparklemotion/sqlite3-ruby#285 + #19 with updated Jenkins file to run conan related deps during install.

@jmarrec
Copy link
Collaborator Author

jmarrec commented Mar 30, 2020

For Nokogiri, ref:
sparklemotion/nokogiri#2015
sparklemotion/nokogiri#2016

This was referenced Mar 30, 2020
@jmarrec jmarrec changed the title Sqlite3 native Upgrade dependencies + Native gems: sqlite3-ruby, nokogiri, jaro_winkler Mar 30, 2020
@jmarrec
Copy link
Collaborator Author

jmarrec commented Mar 30, 2020

@tijcolem I have reverted 125bb61 since it broke the pipeline. We can address that later.

jmarrec and others added 4 commits March 30, 2020 18:23
…cription

cd ~/.conan/data/libxslt/1.1.33/bincrafters/stable/package/9296f4d14bac4f97f90bc8dd0e7a31945380f014/libcp libxslt_a.lib libxslt.lib
cp libexslt_a.lib libexslt.lib
@tijcolem tijcolem merged commit d2b93a7 into NREL:develop Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants