Apply suggestions from code review

Co-authored-by: Mike Wilson <[email protected]> Co-authored-by: Nghia Truong <[email protected]>
NVIDIA · Dec 13, 2023 · 10bfe09 · 10bfe09
1 parent 62ff4f7
commit 10bfe09
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/src/main/cpp/src/cast_string.hpp b/src/main/cpp/src/cast_string.hpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2022-2023-2023, NVIDIA CORPORATION.
+ * Copyright (c) 2022-2023, NVIDIA CORPORATION.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -117,7 +117,7 @@ std::unique_ptr<cudf::column> string_to_float(
 
 std::unique_ptr<cudf::column> format_float(
   cudf::column_view const& input,
-  int digits,
+  int const digits,
   rmm::cuda_stream_view stream,
   rmm::mr::device_memory_resource* mr = rmm::mr::get_current_device_resource());
 

diff --git a/src/main/cpp/src/format_float.cu b/src/main/cpp/src/format_float.cu
@@ -23,6 +23,7 @@
 #include <cudf/strings/detail/strings_children.cuh>
 #include <cudf/utilities/type_dispatcher.hpp>
 
+
 #include <rmm/cuda_stream_view.hpp>
 #include <rmm/exec_policy.hpp>
 
@@ -75,7 +76,7 @@ struct format_float_fn {
 struct dispatch_format_float_fn {
   template <typename FloatType, CUDF_ENABLE_IF(std::is_floating_point_v<FloatType>)>
   std::unique_ptr<cudf::column> operator()(cudf::column_view const& floats,
-                                           int digits,
+                                           int const digits,
                                            rmm::cuda_stream_view stream,
                                            rmm::mr::device_memory_resource* mr) const
   {
@@ -97,7 +98,7 @@ struct dispatch_format_float_fn {
   // non-float types throw an exception
   template <typename T, CUDF_ENABLE_IF(not std::is_floating_point_v<T>)>
   std::unique_ptr<cudf::column> operator()(cudf::column_view const&,
-                                           int,
+                                           int const,
                                            rmm::cuda_stream_view,
                                            rmm::mr::device_memory_resource*) const
   {
@@ -109,7 +110,7 @@ struct dispatch_format_float_fn {
 
 // This will convert all float column types into a strings column.
 std::unique_ptr<cudf::column> format_float(cudf::column_view const& floats,
-                                           int digits,
+                                           int const digits,
                                            rmm::cuda_stream_view stream,
                                            rmm::mr::device_memory_resource* mr)
 {
@@ -120,7 +121,7 @@ std::unique_ptr<cudf::column> format_float(cudf::column_view const& floats,
 
 // external API
 std::unique_ptr<cudf::column> format_float(cudf::column_view const& floats,
-                                           int digits,
+                                           int const digits,
                                            rmm::cuda_stream_view stream,
                                            rmm::mr::device_memory_resource* mr)
 {

diff --git a/src/main/java/com/nvidia/spark/rapids/jni/CastStrings.java b/src/main/java/com/nvidia/spark/rapids/jni/CastStrings.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2022-2023-2023, NVIDIA CORPORATION.
+ * Copyright (c) 2022-2023, NVIDIA CORPORATION.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.