-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for how to add debug symbols [skip ci] #1575
Add docs for how to add debug symbols [skip ci] #1575
Conversation
…jni C++ code. Signed-off-by: Navin Kumar <[email protected]>
build |
CONTRIBUTING.md
Outdated
@@ -248,7 +248,7 @@ Compute Sanitizer either. | |||
If you think your tests are not suitable for Compute Sanitizer, please add the JUnit5 tag (`@Tag("noSanitizer")`) | |||
to the tests or the test class. | |||
``` | |||
@Tag("noSanitizer") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert
./build/run-in-docker | ||
bash-4.2$ cuda-gdb target/cmake-build/gtests/ROW_CONVERSION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: once it is built we do not necessarily have to run it inside docker.
Let us also mention Nsight VSCode extension https://docs.nvidia.com/nsight-visual-studio-code-edition/cuda-debugger/index.html
Signed-off-by: Navin Kumar <[email protected]>
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This adds a note on how to add debug symbols to spark-rapids-jni code in CONTRIBUTING.md. It's based on how debug symbols can be added in libcudf code.
Supersedes idea from #1573