Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for how to add debug symbols [skip ci] #1575

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

NVnavkumar
Copy link
Collaborator

@NVnavkumar NVnavkumar commented Nov 20, 2023

This adds a note on how to add debug symbols to spark-rapids-jni code in CONTRIBUTING.md. It's based on how debug symbols can be added in libcudf code.

Supersedes idea from #1573

@NVnavkumar
Copy link
Collaborator Author

build

@NVnavkumar NVnavkumar self-assigned this Nov 20, 2023
CONTRIBUTING.md Outdated
@@ -248,7 +248,7 @@ Compute Sanitizer either.
If you think your tests are not suitable for Compute Sanitizer, please add the JUnit5 tag (`@Tag("noSanitizer")`)
to the tests or the test class.
```
@Tag("noSanitizer")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

Comment on lines +285 to +286
./build/run-in-docker
bash-4.2$ cuda-gdb target/cmake-build/gtests/ROW_CONVERSION
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: once it is built we do not necessarily have to run it inside docker.

Let us also mention Nsight VSCode extension https://docs.nvidia.com/nsight-visual-studio-code-edition/cuda-debugger/index.html

Signed-off-by: Navin Kumar <[email protected]>
@NVnavkumar
Copy link
Collaborator Author

build

Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NVnavkumar NVnavkumar merged commit ae68c6b into NVIDIA:branch-23.12 Nov 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants