Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download boost package for CI jobs #1672

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Conversation

NvTimLiu
Copy link
Collaborator

@NvTimLiu NvTimLiu commented Jan 2, 2024

To fix: #1671

The old Boost package URL is frequently not available to build CI Docker container. [boost_1_79_0.tar.gz] (https://github.com/NVIDIA/spark-rapids-jni/blob/branch-24.02/ci/Dockerfile#L64).

Update the Boost linkage for CI scripts, to PASS the spark-rapids-jni nightly build/test CI jobs.

Signed-off-by: Tim Liu [email protected]

To fix: NVIDIA#1671

The old Boost package is not available to build CI Docker container.
[boost_1_79_0.tar.gz] (https://github.com/NVIDIA/spark-rapids-jni/blob/branch-24.02/ci/Dockerfile#L64) not available.

Update the correct Boost linkage for CI scripts, to PASS the spark-rapids-jni nightly build/test CI jobs.

Signed-off-by: Tim Liu <[email protected]>
@NvTimLiu NvTimLiu added bug Something isn't working build labels Jan 2, 2024
@NvTimLiu NvTimLiu self-assigned this Jan 2, 2024
@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented Jan 2, 2024

build

Copy link
Contributor

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024 copyrights, otherwise lgtm.

Signed-off-by: Tim Liu <[email protected]>
@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented Jan 3, 2024

build

@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented Jan 3, 2024

Oh as the boost linkage is available again: https://boostorg.jfrog.io/artifactory/main/release/1.79.0/source/boost_1_79_0.tar.gz

CLOSE the PR,

@NvTimLiu NvTimLiu closed this Jan 3, 2024
@NvTimLiu NvTimLiu reopened this Jan 9, 2024
@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented Jan 9, 2024

The old boost linkage is not stable : https://boostorg.jfrog.io/artifactory/main/release/1.79.0/source/boost_1_79_0.tar.gz

image

Change to use the new stable linkage URL

Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NvTimLiu NvTimLiu merged commit f42872a into NVIDIA:branch-24.02 Jan 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Boost package linkage is not available for CI to build and tests
3 participants