-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download boost package for CI jobs #1672
Conversation
To fix: NVIDIA#1671 The old Boost package is not available to build CI Docker container. [boost_1_79_0.tar.gz] (https://github.com/NVIDIA/spark-rapids-jni/blob/branch-24.02/ci/Dockerfile#L64) not available. Update the correct Boost linkage for CI scripts, to PASS the spark-rapids-jni nightly build/test CI jobs. Signed-off-by: Tim Liu <[email protected]>
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2024 copyrights, otherwise lgtm.
Signed-off-by: Tim Liu <[email protected]>
build |
Oh as the boost linkage is available again: https://boostorg.jfrog.io/artifactory/main/release/1.79.0/source/boost_1_79_0.tar.gz CLOSE the PR, |
The old boost linkage is not stable : https://boostorg.jfrog.io/artifactory/main/release/1.79.0/source/boost_1_79_0.tar.gz Change to use the new stable linkage URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
To fix: #1671
The old Boost package URL is frequently not available to build CI Docker container. [boost_1_79_0.tar.gz] (https://github.com/NVIDIA/spark-rapids-jni/blob/branch-24.02/ci/Dockerfile#L64).
Update the Boost linkage for CI scripts, to PASS the spark-rapids-jni nightly build/test CI jobs.
Signed-off-by: Tim Liu [email protected]