Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in a hot fix for a CUDF parquet issue #2742

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Add in a hot fix for a CUDF parquet issue #2742

merged 1 commit into from
Jan 9, 2025

Conversation

revans2
Copy link
Collaborator

@revans2 revans2 commented Jan 8, 2025

This pulls in the patch for rapidsai/cudf#17699 as a hot fix for 24.12.

@revans2
Add in a hot fix for a CUDF parquet issue
09703d7 
Signed-off-by: Robert (Bobby) Evans <[email protected]>
@sameerz
Copy link
Collaborator

sameerz commented Jan 8, 2025

build

@sameerz sameerz added the bug Something isn't working label Jan 9, 2025
@pxLi
Copy link
Collaborator

pxLi commented Jan 9, 2025 •
edited
Loading

cc @NvTimLiu @YanxuanLiu cudf side fix will go to 25.02 directly.
this change is for 24.12, so we will need to revert this patch in 25.02 after rapidsai/cudf#17699 is merged thanks

filed task #2744

gerashegalov
gerashegalov approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pxLi
Copy link
Collaborator

pxLi commented Jan 9, 2025 

[2025-01-08T22:49:39.096Z] [INFO] --- maven-antrun-plugin:3.0.0:run (cudf patch) @ spark-rapids-jni ---
[2025-01-08T22:49:39.096Z] [INFO] Executing tasks
[2025-01-08T22:49:39.096Z] [INFO]      [exec] /home/jenkins/agent/workspace/jenkins-rapids-jni_premerge-github-819/thirdparty/cudf /home/jenkins/agent/workspace/jenkins-rapids-jni_premerge-github-819
[2025-01-08T22:49:39.661Z] [INFO]      [exec] patching with: /home/jenkins/agent/workspace/jenkins-rapids-jni_premerge-github-819/patches/0_hot_fix_parquet.patch
[2025-01-08T22:49:39.661Z] [INFO]      [exec] /home/jenkins/agent/workspace/jenkins-rapids-jni_premerge-github-819
[2025-01-08T22:49:39.661Z] [INFO]      [exec] Checking patch cpp/src/io/parquet/decode_fixed.cu...
[2025-01-08T22:49:39.661Z] [INFO]      [exec] Applied patch cpp/src/io/parquet/decode_fixed.cu cleanly.

CI passed with the expected patch

@pxLi pxLi mentioned this pull request Jan 9, 2025
Closed
@pmattione-nvidia
Copy link
Collaborator

The corresponding cudf PR has been merged into 25.02.

@revans2 revans2 merged commit f230daa into NVIDIA:branch-24.12 Jan 9, 2025
5 checks passed
revans2 added a commit to revans2/spark-rapids-jni that referenced this pull request Jan 9, 2025
@revans2
Revert "Add in a hot fix for a CUDF parquet issue (NVIDIA#2742)"
3813a3e 
This reverts commit f230daa.

Signed-off-by: Robert (Bobby) Evans <[email protected]>
pxLi pushed a commit that referenced this pull request Jan 10, 2025
@revans2
Revert "Add in a hot fix for a CUDF parquet issue (#2742)" (#2748)
53ed880 
This reverts commit f230daa.

This fixes #2744

But should only really go in once we upmerge past the version with the
actual fix in it
(rapidsai/cudf@f13d8fc)

Signed-off-by: Robert (Bobby) Evans <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmattione-nvidia pmattione-nvidia pmattione-nvidia approved these changes

@gerashegalov gerashegalov gerashegalov approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@revans2 @sameerz @pxLi @pmattione-nvidia @gerashegalov