Add keys to ModuleManager
#326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs build test can be fixed by setting |
Thanks @jwaldrop107, added. |
ryanmrichard
requested changes
Dec 7, 2023
ryanmrichard
reviewed
Dec 8, 2023
Co-authored-by: Ryan Richard <[email protected]>
Co-authored-by: Ryan Richard <[email protected]>
Co-authored-by: Ryan Richard <[email protected]>
ryanmrichard
approved these changes
Dec 8, 2023
jwaldrop107
approved these changes
Dec 8, 2023
|
🚀 [bumpr] Bumped! New version:v1.0.17 Changes:v1.0.16...v1.0.17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Brief Description
My intention was to enable iteration for
ModuleManagerin Python. The python bindings required for that is commented out in this PR as it is throwingdouble free or corruption (out)when tested.Instead of that this PR adds
keysmethod as suggested by @jboschen to return a vector of keys for the ModuleManager and python bindings for__getitem__to enable accessing the modules with[]using the key.Not In Scope
PR Checklist