Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmaize refactor #329

Merged
merged 25 commits into from
Dec 29, 2023
Merged

Cmaize refactor #329

merged 25 commits into from
Dec 29, 2023

Conversation

ryanmrichard
Copy link
Member

PR Type

  • Breaking change
  • Feature
  • Patch

Brief Description

This PR refactors the CMakeLists.txt file to showcase CMaize features (it's going to be used as the poster child for the upcoming CMaize paper). It can't be merged until NWChemEx/NWXCMake#36 is merged.

Not In Scope

N/A

PR Checklist

@ryanmrichard ryanmrichard self-assigned this Dec 28, 2023
@ryanmrichard ryanmrichard enabled auto-merge (squash) December 28, 2023 18:53
@ryanmrichard
Copy link
Member Author

How can just the test_build_docs test have a problem with the CMakeLists.txt and none of the other tests?

@ryanmrichard
Copy link
Member Author

Finally! @jwaldrop107 and @zachcran if you're still following this thread this is r2g now!

@ryanmrichard ryanmrichard merged commit 982e2b0 into master Dec 29, 2023
5 checks passed
@ryanmrichard ryanmrichard deleted the cmaize_refactor branch December 29, 2023 19:50
@ryanmrichard
Copy link
Member Author

🚀 [bumpr] Bumped! New version:v1.0.19 Changes:v1.0.18...v1.0.19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants