Patch for Multiple Python Modules #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanmrichard
approved these changes
Jan 24, 2024
keceli
approved these changes
Jan 25, 2024
|
🚀 [bumpr] Bumped! New version:v1.0.24 Changes:v1.0.23...v1.0.24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this pull request associated with an issue(s)?
Associated with #328, but does not resolve it.
Description
These changes are a somewhat hacky patch to deal with the problem identified in #328. Namely, if a
ModuleBaseis identified as originating in python, theModuleManagerstores it in a map specific to python modules. This PR explicitly does not resolve this issue. A more complete solution should replace this when someone has the available cycles.