Refactor logic for hiding scores below median #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-logic-for-hiding-scores-below-median
No change in behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #117.
No change in behaviour.
(May soon become obsolete because #103 proposes to show all scores, but I'd like to do this refactoring anyway)
Previous: IF not-signed-in OR (not-row-of-current-user AND not-admin) THEN hide
Proposed: UNLESS signed-in AND (row-of-current-user OR admin) THEN hide
In other words, the row of the currently signed-in user is always shown, and admins always see the full scoreboard.
(Regarding review: This branch will need to be updated after #117 is merged to resolve conflicts, and that will dismiss reviews. So may as well wait until then before approving.)