Code

Update contest scoreboard#123

Code

Closed

Holmes98 wants to merge 47 commits intomasterNZOI/nztrain:masterfrom scoreboard-update-v2NZOI/nztrain:scoreboard-update-v2Copy head branch name to clipboard

+107-43

Commits

Commits on Feb 6, 2021

• Show all results publiclly.

  Show description for bbb0a51
  

  puqeko

  authored and

  Holmes98

  committed
  bbb0a51

  Copy full SHA for bbb0a51

• Add description about Public/Protected/Private to new contest form.

  

  puqeko

  authored and

  Holmes98

  committed
  23aa9ed

  Copy full SHA for 23aa9ed

• Show contest problem set

  

  puqeko

  authored and

  Holmes98

  committed
  c600659

  Copy full SHA for c600659

• Update contest scoreboard and edit page plus remove info tab.

  Show description for 937df69
  

  puqeko

  authored and

  Holmes98

  committed
  937df69

  Copy full SHA for 937df69

• Fix indentation, add trailing newlines

  Holmes98

  committed
  8b9d651

  Copy full SHA for 8b9d651

• Only show ranks for official contestants

  Show description for 7d6ee47
  Holmes98

  committed
  7d6ee47

  Copy full SHA for 7d6ee47

• Add checkbox to show unofficial contestants

  Holmes98

  committed
  c2a1cb6

  Copy full SHA for c2a1cb6

• Revert lowered opacity for unofficial contestants

  Holmes98

  committed
  2482fe7

  Copy full SHA for 2482fe7

• Add back problem columns and hide scores

  Holmes98

  committed
  6a0aefa

  Copy full SHA for 6a0aefa

• Require school to be blank if outside NZ

  Show description for aca4daa
  Holmes98

  committed
  aca4daa

  Copy full SHA for aca4daa

• Update contest form descriptions

  Holmes98

  committed
  cab715a

  Copy full SHA for cab715a

• Fix default overriding existing contest duration

  Holmes98

  committed
  7190e34

  Copy full SHA for 7190e34

• Fix contest scoreboard with deleted users

  Holmes98

  committed
  48a2b04

  Copy full SHA for 48a2b04

• Fix unofficial contestant filter on Safari

  Holmes98

  committed
  d78da20

  Copy full SHA for d78da20

• Persist checkbox state using localStorage

  Holmes98

  committed
  6f92807

  Copy full SHA for 6f92807

• Hide entire scoreboard if live scoreboard is disabled

  Holmes98

  committed
  d4f97fd

  Copy full SHA for d4f97fd

• Display the flag of the country from contest relation

  Show description for cbaaa99
  Holmes98

  committed
  cbaaa99

  Copy full SHA for cbaaa99

• Rename competitors to contestants

  Holmes98

  committed
  3c838aa

  Copy full SHA for 3c838aa

• Remove schools of users outside New Zealand

  Holmes98

  committed
  e4c35fe

  Copy full SHA for e4c35fe

Commits on Feb 7, 2021

• Rewrite descriptions of scoreboard checkboxes (from code review)

  tom93

  authored
  cbd73df

  Copy full SHA for cbd73df

• Refactor logic for showing scoreboard (suggestion from code review)

  tom93

  authored
  62d6dca

  Copy full SHA for 62d6dca

• Fix bug in logic for hiding scoreboard rows of other users (suggestion from code review)

  Show description for 1c87bd6
  tom93

  authored
  1c87bd6

  Copy full SHA for 1c87bd6

• Revert default 3-hour contest duration

  Show description for 265915e
  tom93

  committed
  265915e

  Copy full SHA for 265915e

• Edit description of Public/Protected/Private in new contest form to reflect current behaviour

  Show description for 12771f3
  tom93

  committed
  12771f3

  Copy full SHA for 12771f3

• Rename column "show_unofficial_contestants" to "only_rank_official_contestants"

  tom93

  committed
  620faf8

  Copy full SHA for 620faf8

• Fix bug in ranking when there are unofficial contestants

  Show description for 5efcbd1
  tom93

  committed
  5efcbd1

  Copy full SHA for 5efcbd1

• Convert variable is_unofficial to is_ranked (its negation)

  Show description for 563fc76
  tom93

  committed
  563fc76

  Copy full SHA for 563fc76

• Fix syntax in JavaScript code to toggle visibility of unofficial contestants

  tom93

  committed
  8ba5b9c

  Copy full SHA for 8ba5b9c

• Use "save!" instead of "save" in remove_schools_for_foreign_users migration to abort on validation failure

  tom93

  committed
  7310e63

  Copy full SHA for 7310e63

• Introduce variable "is_record_of_current_user" in scoreboard view

  tom93

  committed
  b07fbad

  Copy full SHA for b07fbad

• Fix indentation

  tom93

  committed
  0ff54a9

  Copy full SHA for 0ff54a9

• Add back "-" to checkbox labels

  Show description for a817833
  tom93

  committed
  a817833

  Copy full SHA for a817833

Commits on Feb 18, 2021

• Fix <div> closing tags in contest form

  tom93

  committed
  9221380

  Copy full SHA for 9221380

• Remove redundant <br> elements after checkbox labels in contest form

  Show description for 5c9ccb4
  tom93

  committed
  5c9ccb4

  Copy full SHA for 5c9ccb4

Commits on Feb 19, 2021

• Make label for only_rank_official_contestants checkbox more concise

  Show description for 03466fd
  tom93

  committed
  03466fd

  Copy full SHA for 03466fd

• Clarify that unofficial are are still displayed on the scoreboard

  Show description for 8ca52a1
  tom93

  committed
  8ca52a1

  Copy full SHA for 8ca52a1

• Add the "info" tab back

  Show description for e238c34
  tom93

  committed
  e238c34

  Copy full SHA for e238c34

• Update "info" tab to show whether contest scoreboard is live or hidden

  Show description for 1e89762
  tom93

  committed
  1e89762

  Copy full SHA for 1e89762

• Remove invalid <p> element around problems table in contest page

  Show description for df5c053
  tom93

  committed
  df5c053

  Copy full SHA for df5c053

• fixup! Show contest problem set

  Show description for 13be93b
  tom93

  committed
  13be93b

  Copy full SHA for 13be93b

• fixup! Add checkbox to show unofficial contestants

  Show description for 0983a79
  tom93

  committed
  0983a79

  Copy full SHA for 0983a79

• Remove <br> element before submit button in contest form

  Show description for 5cc4f3a
  tom93

  committed
  5cc4f3a

  Copy full SHA for 5cc4f3a

• Add condition to unofficial contestants script

  Show description for 5b24ce3
  Holmes98

  committed
  5b24ce3

  Copy full SHA for 5b24ce3

Commits on Feb 20, 2021

• Clarify label for only_rank_official_contestants checkbox

  Show description for 6318be8
  eric-ide

  authored
  6318be8

  Copy full SHA for 6318be8

Commits on Feb 28, 2021

• Revert "Use "save!" instead of "save" in remove_schools_for_foreign_users migration to abort on validation failure"

  Show description for aede9c9
  Holmes98

  committed
  aede9c9

  Copy full SHA for aede9c9

• Revert "Remove schools of users outside New Zealand"

  Show description for cfa7005
  Holmes98

  committed
  cfa7005

  Copy full SHA for cfa7005

• Revert school abscence validation for users outside NZ

  Show description for cc3355d
  Holmes98

  committed
  cc3355d

  Copy full SHA for cc3355d