Update devise #242
Open
Update devise #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagedevimo
force-pushed
the
01-05-Update_devise
branch
from
14cb6a8 to
adffc6f
Compare
Devise 4.0.0 introduced support for Rails 5 Follow up commits will fix deprecations
Devise updated this in version 4.0.0rc1, so this is just bringing us up to the new system: https://github.com/heartcombo/devise/blob/main/CHANGELOG.md#400rc1---2016-02-01
Devise 4.1.0 fixed a race condition with email sending, where an email could try to be sent before the record that email is referring too is not yet persisted [1]. They unfortunately fixed this using an after_commit, which under Rails 4.2 doesn't work with transactional fixtures [2]. This is fixed under Rails 5 [3], so we can just comment these out to get this merged, and get the rails upgrade out, then re-enable these tests. [1] https://github.com/heartcombo/devise/blob/main/CHANGELOG.md#410 [2] config/spec_helper.rb:34 [3] rails/rails@eb72e34
Devise 4.6.0 deprecated the `devise_error_messages!` helper method in favour if just rendering a partial including the library. [1] We can (optionally) copy that partial into our codebase, where we can edit it, and it will be preferentially used over the one in the gem code. However, the existing helper had no customisations so I didn't go down that route yet. [1] https://github.com/heartcombo/devise/blob/main/CHANGELOG.md#460---2019-02-07
Devise 4.2.0 deprecated the Devise::TestHelpers module in favour of the Devise::Test::ControllerHelpers module, which is because they wanted to split the different test helpers into different modules. https://github.com/heartcombo/devise/blob/main/CHANGELOG.md#420---2016-07-01
bagedevimo
force-pushed
the
01-05-Update_devise
branch
from
adffc6f to
9bedc8e
Compare
Holmes98
approved these changes
Jan 28, 2024
There was a problem hiding this comment.
Seems fine to me, other than the lint issues. I have slight preference to using test_after_commit over commenting out the specs, but I don't feel particularly strongly about it.
| @@ -1,30 +1,36 @@ | |||
| require 'spec_helper' | |||
|
|
|||
| describe Accounts::RegistrationsController do | |||
| it "can get signup form" do | |||
| it 'can get signup form' do | |||
There was a problem hiding this comment.
Is there a particular reason for changing to single quotes? standardrb seems to prefer double quotes:
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping
| post :create, :user => { :username => "signup_username", :name => "Mr. SignUp", :email => "[email protected]", :password => "password", :password_confirmation => "password" } | ||
| end.to change{User.count}.by(1) | ||
| post :create, | ||
| user: { username: 'signup_username', name: 'Mr. SignUp', email: '[email protected]', password: 'password', |
There was a problem hiding this comment.
This also fails lint:
Layout/ArgumentAlignment: Use one level of indentation for arguments following the first line of a multi-line method call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for Rails 5