Switch to default-jre-headless on server for yui-compressor #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagedevimo
previously approved these changes
Jan 5, 2024
Holmes98
approved these changes
May 15, 2024
Was previously openjdk-8-jdk. - yui-compressor only requires the JRE, not the full JDK - GUI libraries aren't required, headless version is enough - the JRE version doesn't really matter, use the default so it gets automatically updated
The lines were copied from script/install/imagemagick.bash and are irrelevant.
tom93
added a commit
that referenced
this pull request
May 15, 2024
Was previously openjdk-8-jdk. - yui-compressor only requires the JRE, not the full JDK - GUI libraries aren't required, headless version is enough - the JRE version doesn't really matter, use the default so it gets automatically updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was previously openjdk-8-jdk.
yui-compressor only requires the JRE, not the full JDK
GUI libraries aren't required, headless version is enough
the JRE version doesn't really matter, use the default so it gets
automatically updated
Also remove unrelated commented-out lines from JRE install script.