Skip to content

Commit

Permalink
Increase the number of pvf execute workers (paritytech#7116)
Browse files Browse the repository at this point in the history
Reference hardware requirements have been bumped to at least 8 cores so
we can no allocate 50% of that capacity to PVF execution.

---------

Signed-off-by: Alexandru Gheorghe <[email protected]>
  • Loading branch information
alexggh authored and Nathy-bajo committed Jan 21, 2025
1 parent c8db1d5 commit ddd03c6
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 8 deletions.
11 changes: 3 additions & 8 deletions polkadot/node/service/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -944,14 +944,9 @@ pub fn new_full<
secure_validator_mode,
prep_worker_path,
exec_worker_path,
pvf_execute_workers_max_num: execute_workers_max_num.unwrap_or_else(
|| match config.chain_spec.identify_chain() {
// The intention is to use this logic for gradual increasing from 2 to 4
// of this configuration chain by chain until it reaches production chain.
Chain::Polkadot | Chain::Kusama => 2,
Chain::Rococo | Chain::Westend | Chain::Unknown => 4,
},
),
// Default execution workers is 4 because we have 8 cores on the reference hardware,
// and this accounts for 50% of that cpu capacity.
pvf_execute_workers_max_num: execute_workers_max_num.unwrap_or(4),
pvf_prepare_workers_soft_max_num: prepare_workers_soft_max_num.unwrap_or(1),
pvf_prepare_workers_hard_max_num: prepare_workers_hard_max_num.unwrap_or(2),
})
Expand Down
8 changes: 8 additions & 0 deletions prdoc/pr_7116.prdoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
title: Increase the number of pvf execution workers from 2 to 4
doc:
- audience: Node Dev
description: |-
Increase the number of pvf execution workers from 2 to 4.
crates:
- name: polkadot-service
bump: patch

0 comments on commit ddd03c6

Please sign in to comment.