fix https jar url (#743)

Netflix · Jan 9, 2025 · 9ddcd1b · 9ddcd1b
1 parent 320ddcb
commit 9ddcd1b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/...lane-server/src/main/java/io/mantisrx/master/jobcluster/proto/JobClusterManagerProto.java b/...lane-server/src/main/java/io/mantisrx/master/jobcluster/proto/JobClusterManagerProto.java
@@ -557,7 +557,7 @@ public UpdateJobClusterArtifactRequest(
             // json property "url".
             this.jobJarUrl = jobJarUrl != null ?
                 jobJarUrl :
-                (artifact.startsWith("http://") ? artifact : "http://" + artifact);
+                (artifact.startsWith("http://") || artifact.startsWith("https://") ? artifact : "http://" + artifact);
             this.version = version;
             this.skipSubmit = skipSubmit;
             this.user = user;

diff --git a/...-control-plane-server/src/test/java/io/mantisrx/master/jobcluster/JobClusterAkkaTest.java b/...-control-plane-server/src/test/java/io/mantisrx/master/jobcluster/JobClusterAkkaTest.java
@@ -811,6 +811,16 @@ public void testJobClusterArtifactUpdateBackCompat() throws Exception {
             "user");
         assertEquals("artifact1-1.zip", req2.getArtifactName());
         assertEquals("http://artifact1-1.zip", req2.getjobJarUrl());
+
+        UpdateJobClusterArtifactRequest req3 = new UpdateJobClusterArtifactRequest(
+            clusterName,
+            "https://path1/artifact1-1.zip",
+            null,
+            "1",
+            true,
+            "user");
+        assertEquals("https://path1/artifact1-1.zip", req3.getArtifactName());
+        assertEquals("https://path1/artifact1-1.zip", req3.getjobJarUrl());
     }
 
     @Test