Cleaning up docker build process #559
Conversation
sundargates
requested review from
nickmahilani,
jeffchao,
piygoyal,
calvin681,
Andyz26,
hmitnflx,
markcho,
liuml07 and
fdc-ntflx
as code owners
sundargates
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Test Results128 files ±0 128 suites ±0 7m 12s ⏱️ +25s For more details on these failures, see this check. Results for commit bdd5c75. ± Comparison against base commit d1bef3c. ♻️ This comment has been updated with latest results. |
sundargates
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
sundargates
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
| def installDir = file("${buildDir}/install") | ||
| def controlPlaneState = file("${project.resources}/docker") | ||
| def ci = System.getenv('GITHUB_ACTIONS') | ||
| def imageRepository = ci ? 'netflixoss' : 'localhost:5001/netflixoss' |
There was a problem hiding this comment.
Add a comment here that we assume local docker registry running on 5001
| } | ||
|
|
||
| javaApplication { | ||
| baseImage = 'azul/zulu-openjdk:8-latest' |
There was a problem hiding this comment.
This comment is not related to this PR. Can you try changing to this to jdk17 and see what happens when you launch with helm?
| @@ -19,6 +19,7 @@ plugins { | |||
| } | |||
|
|
|||
| apply plugin: 'application' | |||
| apply plugin: 'com.bmuschko.docker-java-application' | |||
There was a problem hiding this comment.
Shall we lock version on this plugin too?
| entryPoint './bin/start.sh' | ||
| } | ||
|
|
||
| javaApplication { |
There was a problem hiding this comment.
javaApplication will create an entryPoint in the generated Dockerfile. And then the previous dockerCreateDockerfile section will also create an entryPoint. is that OK? I'm not sure if the generated Dockerfile is actually valid.
There was a problem hiding this comment.
Yeah, the second entry point overrides the first one. I have tested it end to end, and I can give a demo if you would like.
sundargates
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
sundargates
force-pushed
the
sundaram/docker
branch
from
0102985 to
c64a6a2
Compare
sundargates
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
sundargates
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
sundargates
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
sundargates
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
sundargates
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Context
I’d like to outline the goals for this PR.
Firstly, it aims to integrate the docker build process with the build system instead of having it defined in various places such as shell, gradle, and the dockerfile.
Secondly, it aims to set up the server with a few job clusters, making it easier to launch these clusters with the helm setup.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests