Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TE connection improvement #564

Merged
merged 1 commit into from
Oct 13, 2023
Merged

TE connection improvement #564

merged 1 commit into from
Oct 13, 2023

Conversation

Andyz26
Copy link
Collaborator

@Andyz26 Andyz26 commented Oct 13, 2023

Context

Problem:
TEs can get into connection problems where the TE gateway keeps failing causing frequent worker restarts and exhausting the idle pool.

  • Refactor and clean up reconnection logic (handle the reconnection inside the TE gateway directly).
  • Support scheduling rate limiter (this is supported via Fenzo on mesos but not supported on Titus).

Checklist

  • ./gradlew build compiles code correctly
  • Added new tests where applicable
  • ./gradlew test passes all tests
  • Extended README or added javadocs where applicable

@Andyz26 Andyz26 had a problem deploying to Integrate Pull Request October 13, 2023 22:21 — with GitHub Actions Failure
@github-actions
Copy link

Test Results

545 tests  ±0   537 ✔️ ±0   7m 0s ⏱️ -9s
128 suites ±0       8 💤 ±0 
128 files   ±0       0 ❌ ±0 

Results for commit 72b406c. ± Comparison against base commit cd735c5.

@Andyz26 Andyz26 merged commit 20e5d26 into master Oct 13, 2023
4 of 5 checks passed
@Andyz26 Andyz26 deleted the andyz/teReconnectRefactor branch October 13, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickmahilani nickmahilani Awaiting requested review from nickmahilani

@jeffchao jeffchao Awaiting requested review from jeffchao

@piygoyal piygoyal Awaiting requested review from piygoyal

@calvin681 calvin681 Awaiting requested review from calvin681 calvin681 is a code owner

@sundargates sundargates Awaiting requested review from sundargates

@hmitnflx hmitnflx Awaiting requested review from hmitnflx hmitnflx is a code owner

@markcho markcho Awaiting requested review from markcho

@liuml07 liuml07 Awaiting requested review from liuml07

@fdc-ntflx fdc-ntflx Awaiting requested review from fdc-ntflx fdc-ntflx is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Andyz26