-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Upgrade JDK target to 17 #735
base: master
Are you sure you want to change the base?
Conversation
@crioux-stripe @kmg-stripe @garryliu-stripe How do you feel about the moving towards jdk17 for the OSS components? Any thing internal you need to keep on jdk8? This is still early draft and I have some internal validation to do but I would like to see how you folks feel about this early. |
Test Results142 files ±0 142 suites ±0 8m 1s ⏱️ -27s Results for commit 1909c32. ± Comparison against base commit 35a0826. This pull request skips 1 test.
♻️ This comment has been updated with latest results. |
Uploaded ArtifactsTo use these artifacts in your Gradle project, paste the following lines in your build.gradle.
|
@Andyz26 I think we'd be pretty keen to move to JDK 17! We're running 11 on the Mantis hosts right now but most of our Java monorepo is 17+. I don't think anything is preventing us from running 17, and we may have prototyped with it IIRC. |
Context
Upgrade project to target JDK17.
Checklist
./gradlew build
compiles code correctly./gradlew test
passes all tests