Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scaling #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix scaling #34

wants to merge 1 commit into from

Conversation

gontovnik
Copy link

See #33 for more context. Removing this centering logic fixes the issue and makes the exporter rely on the AVVideoScalingModeKey.

I might be lacking some context and the proposed solution might break some scenarios that I am not aware of. I am open to any feedback ;)

@sjmueller
Copy link

Just FYI this doesn't fix some videos with transforms, especially with iOS screen recordings that have been cropped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants