Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] 홈 모듈 생성 및 홈-프로필 네비게이션 연결 #29

Merged
merged 7 commits into from
Feb 3, 2024

Conversation

ham2174
Copy link
Collaborator

@ham2174 ham2174 commented Feb 1, 2024

관련 이슈

작업한 내용

  • :feature:home 모듈이 새롭게 생성었습니다.
  • 기존 FunchApp()에서 홈 Screen을 그렸던 작업을 :feature:home에서 Screen을 구성하도록 변경되었습니다.
  • :feature:profile 모듈에 CreateProfileScreen과 MyProfileScreen이 생성되었습니다.
  • :app 모듈의 ../navigation 패키지에서 FunchNavHost()가 추가되었습니다.
  • 이제 :app 모듈의 ../ui/FunchApp.kt에서 Surface를 정의하고 FunchNavHost()를 불러옵니다.
  • 프로필 생성페이지 - 홈 - 내 프로필 Screen이 연결되었습니다.

PR 포인트

  • home 모듈 생성
  • navigation 연결

🚀Next Feature

  • 진짜 내 프로필 UI 제작...

@ham2174 ham2174 requested a review from murjune February 1, 2024 11:18
@ham2174 ham2174 self-assigned this Feb 1, 2024
Copy link
Member

@murjune murjune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네비게이션 처음 써보셨을 텐데 아주 잘하셨네요 LGTM 👍👍👍

comment 확인해주세용

@murjune murjune added the ham😸 Good for newcomers label Feb 3, 2024
@murjune
Copy link
Member

murjune commented Feb 3, 2024

고생하셨습니당👍

@ham2174 ham2174 merged commit 7eee4ac into develop Feb 3, 2024
1 check passed
@ham2174 ham2174 deleted the feature/create-my-profile-navigate branch February 3, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ham😸 Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants