Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] FunchChip matched 시 border 및 neonSign 효과 구현 #31

Merged
merged 6 commits into from
Feb 4, 2024

Conversation

murjune
Copy link
Member

@murjune murjune commented Feb 3, 2024

관련 이슈

  • closed #이슈넘버

작업한 내용

  • FunchChip matched 시 border 및 neonSign 효과 구현

PR 포인트

  • 상대와 겹치는 프로필 Chip borderStroke, neonSign

image

@murjune murjune added the june🙇‍♂️ New feature or request label Feb 3, 2024
@murjune murjune requested a review from a team February 3, 2024 04:20
@murjune murjune self-assigned this Feb 3, 2024
Copy link
Collaborator

@ham2174 ham2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

귯귯~ 바로 머지할게용! 불필요한 주석 하나는 제가 처리하겠습니다~~

@@ -138,7 +162,9 @@ data class PunchChipColors(
private val selectedLabelColor: Color = White,
private val disabledLabelColor: Color = Gray400,
private val disabledSelectedLabelColor: Color = White,
// private val
Copy link
Collaborator

@ham2174 ham2174 Feb 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거 불필요한 주석은 #39 에서 제거할게요잇!

@ham2174 ham2174 merged commit 12bb868 into develop Feb 4, 2024
1 check passed
@ham2174 ham2174 deleted the feature/add-chip-border-property branch February 4, 2024 18:48
@ham2174 ham2174 mentioned this pull request Feb 4, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
june🙇‍♂️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants