psx: work-around hsc2hs linking issue
#60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasT
force-pushed
the
hsc2hs-linkage-issue
branch
from
24242a5 to
035dacf
Compare
On some platforms, building a `hsc2hs` program requires `libgcc`, and on some platforms, `libgcc` uses `sigfillset`. For some reason (a bug, I'd say), `cabal` passes `ld-options` to the compiler when building the generated C file. In our case, this causes `sigfillset` to be wrapped (which is desired for the actual `psx` library), but since `__wrap_sigfillset` is never defined, the build fails. This work-around tells `hsc2hs` to include a small C file in its generated sources which defines `__wrap_sigfillset` as a proxy for `__real_sigfillset`. This requires the Cabal format to be bumped to 3.6. See: haskell/cabal#8824
NicolasT
force-pushed
the
hsc2hs-linkage-issue
branch
from
035dacf to
49f6643
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some platforms, building a
hsc2hsprogram requireslibgcc, and on some platforms,libgccusessigfillset. For some reason (a bug, I'd say),cabalpassesld-optionsto the compiler when building the generated C file. In our case, this causessigfillsetto be wrapped (which is desired for the actualpsxlibrary), but since__wrap_sigfillsetis never defined, the build fails.This work-around tells
hsc2hsto include a small C file in its generated sources which defines__wrap_sigfillsetas a proxy for__real_sigfillset.See: haskell/cabal#8824