Skip to content
This repository has been archived by the owner on Oct 17, 2023. It is now read-only.

Commit

Permalink
Fix the flawed submission to coveralls.io
Browse files Browse the repository at this point in the history
Also clarify the contribution workflow about test coverage.
  • Loading branch information
ericmorand committed Oct 17, 2023
1 parent f7a7a60 commit 0f5617f
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 13 deletions.
4 changes: 0 additions & 4 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
.idea/
npm-debug.log*
node_modules/
coverage
dist
.nyc_output
package-lock.json
7 changes: 5 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ jobs:
include:
- stage: cover
node_js: 19
before_script:
- npm i nyc --global
- curl -L https://coveralls.io/coveralls-linux.tar.gz | tar -xz -C .
script:
- npm run cover
- npm run coverage
- nyc npm test
- nyc report --reporter=text-lcov > coverage/lcov.info && ./coveralls report
9 changes: 8 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,17 @@ Read the [documentation](https://nightlycommit.github.io/html-source-map-rebase)

## Contributing

### Prerequisites

* [nyc](https://www.npmjs.com/package/nyc)

### Usage

* Fork the main repository
* Code
* Implement tests using [tape](https://www.npmjs.com/package/tape)
* Issue a pull request keeping in mind that all pull requests must reference an issue in the issue queue
* Check the test coverage by executing `nyc npm run test`
* Issue a pull request keeping in mind that all pull requests must reference an issue in the issue queue and must maintain a 100% test coverage

## License

Expand Down
7 changes: 1 addition & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,9 @@
"clean": "rimraf dist",
"prepack": "npm run clean && npm run build",
"prebuild": "npm run clean",
"precover": "rimraf coverage",
"test": "ts-node node_modules/tape/bin/tape test/**/*.test.ts | tap-spec",
"build": "tsc --project . --module commonjs --outDir dist --declaration true",
"build:doc": "typedoc src/index.ts --out docs --excludePrivate --excludeProtected --excludeExternals",
"cover": "nyc npm t",
"coverage": "nyc report --reporter=text-lcov | coveralls"
"build:doc": "typedoc src/index.ts --out docs --excludePrivate --excludeProtected --excludeExternals"
},
"repository": {
"type": "git",
Expand All @@ -40,8 +37,6 @@
"@types/parse5-html-rewriting-stream": "^5.1.2",
"@types/parse5-sax-parser": "^5.0.2",
"@types/tape": "^5.6.1",
"coveralls": "^3.0.2",
"nyc": "^13.0.1",
"parse5-sax-parser": "^5.0.0",
"rimraf": "^2.6.2",
"tap-spec": "^5.0.0",
Expand Down

0 comments on commit 0f5617f

Please sign in to comment.