No battery options for G7 #3295
Conversation
Merge remote-tracking branch 'Navid200/Navid_2024_01_05' into schubi
|
Using the new best collector G7 setting. The logic is negative. But, that's OK. Tested after the latest update with G7 and G6 and looks good.
|
| @@ -1731,6 +1732,12 @@ public boolean onPreferenceChange(Preference preference, Object newValue) { | |||
| } | |||
| } | |||
|
|
|||
| if (getBestCollectorHardwareName().equals("G7")) { // Remove battery options, from G5/G6/Dex1/G7 Debug Settings, if we are using G7 or One+ | |||
There was a problem hiding this comment.
Really good idea to wrap this with a try{} catch{} pair and log at wtf level if an exception is generated, otherwise future changes to preferences structure can cause crashes.
There was a problem hiding this comment.
Sure, thanks. It will be done.
|
After the last edit of adding try, exception, the following is the extent of the tests I performed: On Android 8, selected Dex as hardware data source. Changed the number of characters back to 6. The battery option was still missing. Again, I needed to go to home screen and go to settings again and then, the battery option was gone. I don't think this is a problem. |
|
Thanks |
Since we don't want to offer the option to customize the battery warning level for G7, this PR removes the setting.
The title of the category has been updated to exclude G7.
It has been tested with G6 and G7.