-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't translate Last Connected #3596
Conversation
I think instead we should think about how the status page can be localized to make it easier for non-english speakers to understand what is there but also so it can be reverted to english for support purposes. |
Please look at the following image: You can see that on the sensor status line, the phrase "sensor status" is not translated. But, the word after 11.2 is translated. So, on the same line, we have some words in English and one in another language. Considering we have words on the same lines in different languages, this cannot be intentional. PR that caused this The only change I am making in this PR is to make the Dex status page consistent with respect to translation. Helping those who don't speak English In my opinion, however, that is not the right approach. Please reconsider. |
My view is that we should focus on what is best for the users and so I think the goals should be:
To this end I propose to implement a screenshot button in the status page which when pressed will generate a screenshot in English and then offer to save/share that file to make it easier for the user to find. If they want to screenshot in their native language then they can just use the regular phone based screenshot button combo. |
OK |
I already have this all implemented which I did before to check feasibility of the concept. |
OK |
This is what is shown on the Dex status page when a language other than English is selected.
As you can see some items are translated and some aren't.
We don't translate anything in the logs. For the same reason, we also should not translate items on the status page that are needed for helping someone troubleshoot.
The last connected item is very critical.
If last connected is less than 5 minutes, it is a good sign. if it is not, there could be a connectivity issue. When there is a problem, this parameter is one of the first I need to see when helping someone troubleshoot.
But, if it is translated, I will have to translate it back.
This PR changes the behavior such that last connected on the Dex status page is not translated as you can see here:
My first attempt at this was very primitive: #3303
I have now added an optional parameter to the method.
All the existing calls go to the method without the new parameter resulting in translation as they did before this PR.
Only one call to the method, on the Dex status page, sets the new parameter to true forcing the language to be English.