Daily intent service no charging requirement #3823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The daily intent service runs everyday even when the phone is not being charged. |
jamorham
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see: #3815
I don't believe we have an issue if the daily intent service does not run daily as long as it runs at least once a week.
But, I have a concern about the requirements. We currently have a requirement of the phone being in the process of being charged.
What if the battery level is extremely low? Wouldn't it be a bad idea to run then even if it was being charged?
This PR replaces the requirement of being charged with a requirement of the battery level not being low.
Tests
In progress