Fix the parsing of the query of path-like flakerefs #10125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
with-tests
added 3 commits
March 2, 2024 10:11
Make sure that various combinations of query strings, fragments, relative and absolute paths behave properly.
The query parameters for path flakerefs (`/foo/bar?query=blah` or `.?foo=bar`) was ignored when the path wasn't a git repo. Fix that
`/path?foo=bar` was parsed as `/path`, omitting the query altogether (`/path?foo=bar#` was parsed correctly though). Rewrite the path flake ref parser to fix this
thufschmitt
force-pushed
the
fix-path-flakeref-query-parsing
branch
from
882e139 to
3740cdb
Compare
|
Rewrote the test to directly test the |
Merged
|
@Ericson2314 I'm a bit stuck on the tests here because they require |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-55/40996/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
On current master, a flake-like pathref with a query but no fragment will quietly drop the query.
For instance,
nix build .?rev=c43c75ea7983f84270cfdcca18169c03987287a4will quietly ignore therevparameter and behave likenix build ..Fix that, and add some tests.
Context
Spotted as part of #6633.
Probably introduced by #6614.
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.