-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.nbclassic: fix build failure due to nodejs deps #186703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofrim
added
8.has: package (new)
This PR adds a new package
0.kind: build failure
A package fails to build
labels
Aug 14, 2022
@ofborg build python310Packages.nbclassic python310Packages.jupyterlab |
Ah, it cannot build on ofborg because of the insecure dependency. |
Result of 1 package marked as broken and skipped:
3 packages failed to build:
7 packages built:
|
SuperSandro2000
changed the title
pythonPackages.nbclassic: proposal for fixing build failure due to nodejs deps
pythonPackages.nbclassic: fix build failure due to nodejs deps
Aug 15, 2022
mofrim
force-pushed
the
fix-nbclassic
branch
2 times, most recently
from
August 15, 2022 16:49
da130e5
to
ddddfc7
Compare
mofrim
commented
Aug 15, 2022
13 tasks
smancill
reviewed
Aug 17, 2022
Result of 1 package marked as broken and skipped:
3 packages failed to build:
7 packages built:
|
smancill
approved these changes
Aug 17, 2022
smancill
added
the
12.approvals: 1
This PR was reviewed and approved by one reputable person
label
Aug 17, 2022
Result of 4 packages failed to build:
9 packages built:
nix log /nix/store/gx97h2k4rdyd7jb7yj1mh5bk85gxs3cz-python3.9-jupyterlab_server-2.15.0.drv (build failure)
|
fogti
approved these changes
Aug 18, 2022
This was referenced Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0.kind: build failure
A package fails to build
6.topic: python
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
12.approvals: 1
This PR was reviewed and approved by one reputable person
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
using v4.3.0
nbclassic
github version as src for this package would require dealing with bower nodejs dependencies which would be, given the fact that bower is almost deprecated, cumbersome to deal with directly (i tried for a while...).So i decided to use the Pypi-version where all node-deps are included. Also an new dependency
notebook_shim
had to be packaged.I only started looking into this matter because another package i maintain
manim
did not build anymore because of nbclassic not building.Unfortunately ATM nbclassic only builds with
export NIXPKGS_ALLOW_INSECURE=1
because ofpythonPackages.mistune
, see also PR #186272.Closes #186694, closes #185028.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes