Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desktop-postflop: init at 0.2.7 #252951

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Sep 2, 2023

Description of changes

Closes #251620

This PR adds 1 package: desktop-postflop

This is a tauri app.
The packaging steps were partially based on how the xplorer package did it.

I have found that, because I'm using proprietary nvidia drivers, it seems to show a blank screen unless I set WEBKIT_DISABLE_COMPOSITING_MODE=1
https://bugs.webkit.org/show_bug.cgi?id=228268

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@TomaSajt TomaSajt marked this pull request as draft November 5, 2023 17:59
@TomaSajt TomaSajt changed the title desktop-postflop: init at 0.2.6 desktop-postflop: init at 0.2.7 Nov 5, 2023
@TomaSajt TomaSajt marked this pull request as ready for review November 5, 2023 18:45
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 252951 run on x86_64-linux 1

1 package built:
  • desktop-postflop

@FliegendeWurst FliegendeWurst added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 5, 2023
@TomaSajt TomaSajt force-pushed the desktop-postflop branch 2 times, most recently from 76b9f16 to 9db62d1 Compare January 16, 2024 14:09
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 8, 2024
@pbsds
Copy link
Member

pbsds commented Jun 5, 2024

Result of nixpkgs-review pr 252951 run on x86_64-linux 1

1 package built:
  • desktop-postflop

@pbsds pbsds merged commit cf263f4 into NixOS:master Jun 5, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: desktop-postflop
4 participants