-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: drop poetry2nix #263308
treewide: drop poetry2nix #263308
Conversation
How's the in-tree poetry2nix broken? And why can't we just update it to fix it? |
It was broken by the Python bootstrap changes, and we don't really want to update it because the out-of-tree version is generally better, because it has a lot more overrides and adds them a lot faster. We also don't want to encourage new poetry2nix consumers in-tree. |
9c5a48e
to
a7b6072
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a release manager seal ✔️.
Marking as draft to prevent accidental merges. |
Fixed eval error. |
ps.nixops-hetzner | ||
ps.nixops-hetznercloud | ||
ps.nixops-libvirtd | ||
ps.nixops-vbox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reasoning behind adding these nine by default rather than all of them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what the previous version of the expression did.
pkgs/applications/networking/cluster/nixops/plugins/nixops-libvirtd.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/networking/cluster/nixops/plugins/nixops-libvirtd.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/networking/cluster/nixops/plugins/nixops-vbox.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/networking/cluster/nixops/plugins/nixos-modules-contrib.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/networking/cluster/nixops/plugins/nixos-modules-contrib.nix
Show resolved
Hide resolved
Updated to latest version of nixops with all the fixes, also added updateScript everywhere. |
This should be good to go now, though I'd prefer to get explicit agreement from people added as maintainers before we merge. |
It's dead, Jim.
Since the nixops directory is going away.
Tries to do networky stuff?
Mostly nix-init with some manual fixups. withPlugins implementation copied from Poetry.
The in-tree version has been broken for a while, so now is probably a good time to rip off the band-aid.
Thanks for waiting, I'm happy to maintain my plugin's nix-expression here. |
I'm just going to merge this, and if @Kiwi wants to step down, they're welcome to. I'm really worried about this bitrotting. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/how-can-i-install-nixops/39957/4 |
Description of changes
poetry2nix in-tree was broken in a pretty major way for a while now, and the only remaining consumers in nixpkgs itself were NixOps versions. So, drop NixOps stable (it's on Python 2, which is very dead), rework NixOps unstable to use nixpkgs dependencies, and finally drop poetry2nix itself.
I've taken the liberty to add upstream maintainers as maintainers to the respective NixOps plugins - if you'd like to be excluded, please say so.
TODO
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)