Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.arxiv-latex-cleaner: init at 1.0.5 #301137

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChrisPattison
Copy link
Contributor

Description of changes

python311Packages.arxiv-latex-cleaner: init at 1.0.5

arxiv-latex-cleaner
is a tool for sanitizing latex sources before posting to arxiv

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Apr 3, 2024

buildPythonPackage rec {
pname = "arxiv-latex-cleaner";
version = "1.0.5";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "1.0.5";
version = "1.0.8";

buildPythonPackage rec {
pname = "arxiv-latex-cleaner";
version = "1.0.5";
format = "pyproject";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
format = "pyproject";
pyproject = true;

hash = "sha256-Yxp8XtlISVZfEjCEJ/EXsIGMCHDPOwPcjkJxECeXvYk=";
};

nativeBuildInputs = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nativeBuildInputs = [
build-system = [

pythonRelaxDepsHook
];

propagatedBuildInputs = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
propagatedBuildInputs = [
dependencies = [

pythonImportsCheck = [ "arxiv_latex_cleaner" ];

meta = {
description = "This tool allows you to easily clean the LaTeX code of your paper to submit to arXiv.";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "This tool allows you to easily clean the LaTeX code of your paper to submit to arXiv.";
description = "Tool to clean the LaTeX code of your paper to submit to arXiv";

@@ -1,3 +1,4 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@FliegendeWurst FliegendeWurst added the awaiting_changes (old Marvin label, do not use) label Dec 5, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 10, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2025
@SigmaSquadron SigmaSquadron removed the awaiting_changes (old Marvin label, do not use) label Jan 5, 2025
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 5, 2025
@aucub aucub added the 2.status: duplicate This is a duplicate of another issue or PR label Jan 22, 2025
@aucub aucub closed this Jan 22, 2025
@aucub aucub reopened this Jan 22, 2025
@aucub aucub removed the 2.status: duplicate This is a duplicate of another issue or PR label Jan 22, 2025
@nix-owners nix-owners bot requested a review from natsukium January 22, 2025 20:46
@FliegendeWurst
Copy link
Member

No you are right, it is a duplicate. arxiv-latex-cleaner was added as a top-level package, which makes more sense anyway.

@FliegendeWurst FliegendeWurst marked this pull request as draft January 22, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants