Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

element-desktop: 1.11.67 -> 1.11.68 #317579

Merged
merged 1 commit into from
Jun 8, 2024
Merged

element-desktop: 1.11.67 -> 1.11.68 #317579

merged 1 commit into from
Jun 8, 2024

Conversation

teutat3s
Copy link
Member

@teutat3s teutat3s commented Jun 5, 2024

Description of changes

https://github.com/element-hq/element-desktop/releases/tag/v1.11.68
Bumped electron to version 30, following upstream.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jun 5, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jun 7, 2024
@teutat3s teutat3s mentioned this pull request Jun 7, 2024
Merged
13 tasks
yayayayaka
yayayayaka approved these changes Jun 8, 2024
View reviewed changes
Copy link
Member

@yayayayaka yayayayaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine on x86_64-linux on wayland, thanks!

@yayayayaka yayayayaka merged commit 3a6b13c into NixOS:master Jun 8, 2024
30 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 8, 2024

Successfully created backport PR for release-23.11:

This was referenced Jun 8, 2024
Closed
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 8, 2024

Successfully created backport PR for release-24.05:

@teutat3s teutat3s deleted the element-desktop-1.11.68 branch June 8, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtbx jtbx jtbx approved these changes

@yayayayaka yayayayaka yayayayaka approved these changes

@mguentner mguentner Awaiting requested review from mguentner

@Ma27 Ma27 Awaiting requested review from Ma27

@dali99 dali99 Awaiting requested review from dali99

@NickCao NickCao Awaiting requested review from NickCao

@Ralith Ralith Awaiting requested review from Ralith

@sumnerevans sumnerevans Awaiting requested review from sumnerevans

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@teutat3s @yayayayaka @jtbx @wegank