Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/test-driver: fix return value of subtest function #317582

Merged
merged 2 commits into from
Jun 6, 2024
Merged

nixos/test-driver: fix return value of subtest function #317582

merged 2 commits into from
Jun 6, 2024

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Jun 5, 2024 •
edited
Loading

Mypy since version 1.10.0 complains about this:

test_driver/driver.py:109: error: No return value expected [return-value]

cc #317301 (comment)

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@mweinelt mweinelt added the 1.severity: channel blocker Blocks a channel label Jun 5, 2024
@mweinelt mweinelt requested a review from tfc as a code owner June 5, 2024 22:50
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: testing Tooling for automated testing of packages and modules 6.topic: python labels Jun 5, 2024
mweinelt added 2 commits June 6, 2024 01:07
@mweinelt
nixos/test-driver: fix return value of subtest function
ab897a8 
Mypy since version 1.10.0 complains about this:

> test_driver/driver.py:109: error: No return value expected  [return-value]
@mweinelt
python312Packages.mypy: run nixos-test-driver test in passthru
6791c1a 
Failing typing checks on the test-driver result in channel blockers.
@mweinelt mweinelt force-pushed the test-driver-subtest-return-type branch from 7bf6737 to 6791c1a Compare June 5, 2024 23:07
@mweinelt mweinelt changed the title nixos/test-driver: fix return type of subtest function nixos/test-driver: fix return value of subtest function Jun 5, 2024
@mweinelt mweinelt mentioned this pull request Jun 5, 2024
Merged
13 tasks
@K900 K900 merged commit 7bf4340 into NixOS:master Jun 6, 2024
28 of 29 checks passed
@mweinelt mweinelt deleted the test-driver-subtest-return-type branch June 6, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@tfc tfc Awaiting requested review from tfc

Assignees
No one assigned
Labels
1.severity: channel blocker Blocks a channel 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 6.topic: testing Tooling for automated testing of packages and modules 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mweinelt @SuperSandro2000 @K900