Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nexusmods-app-unfree: 0.4.1 -> 0.5.3 #329592

Closed

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for nexusmods-app-unfree is: Game mod installer, creator and manager

meta.homepage for nexusmods-app-unfree is: https://github.com/Nexus-Mods/NexusMods.App

meta.changelog for nexusmods-app-unfree is: https://github.com/Nexus-Mods/NexusMods.App/releases/tag/v0.5.3

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • Warning: a test defined in passthru.tests did not pass
  • found 0.5.3 with grep in /nix/store/89hpr47p39b9shb16rhcy3rl5jxmx7mr-nexusmods-app-0.5.3
  • found 0.5.3 in filename of file in /nix/store/89hpr47p39b9shb16rhcy3rl5jxmx7mr-nexusmods-app-0.5.3

Rebuild report (if merged into master) (click to expand)
3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

nexusmods-app
nexusmods-app-unfree
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/89hpr47p39b9shb16rhcy3rl5jxmx7mr-nexusmods-app-0.5.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A nexusmods-app-unfree https://github.com/r-ryantm/nixpkgs/archive/e008e05c73ae3ef4a72a9602341fa32c8d88ff9e.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/e008e05c73ae3ef4a72a9602341fa32c8d88ff9e#nexusmods-app-unfree

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/89hpr47p39b9shb16rhcy3rl5jxmx7mr-nexusmods-app-0.5.3
ls -la /nix/store/89hpr47p39b9shb16rhcy3rl5jxmx7mr-nexusmods-app-0.5.3/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:
  • nexusmods-app
1 package built:
  • nexusmods-app-unfree

Maintainer pings

cc @l0b0 @MattSturgeon for testing.

@ofborg ofborg bot requested review from MattSturgeon and l0b0 July 24, 2024 07:42
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jul 24, 2024
@MattSturgeon
Copy link
Contributor

Builds fine, but attempting to run the app results in:

Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.Extensions.DependencyInjection, Version=8.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'. The system cannot find the file specified.

File name: 'Microsoft.Extensions.DependencyInjection, Version=8.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'
   at Microsoft.Extensions.Hosting.HostBuilder..ctor()
   at NexusMods.App.Program.BuildSettingsHost() in /build/source/src/NexusMods.App/Program.cs:line 180
   at NexusMods.App.Program.Main(String[] args) in /build/source/src/NexusMods.App/Program.cs:line 42
fish: Job 1, './result/bin/NexusMods.App' terminated by signal SIGABRT (Abort)

In addition to that, we will need to incorporate other changes, such as those in #318647

@NickCao NickCao marked this pull request as draft July 27, 2024 14:04
@MattSturgeon MattSturgeon mentioned this pull request Jul 30, 2024
20 tasks
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 10, 2024
@r-ryantm r-ryantm deleted the auto-update/nexusmods-app-unfree branch September 29, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants