Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eddie: init at 2.24.4 #332532

Merged
merged 1 commit into from
Dec 12, 2024
Merged

eddie: init at 2.24.4 #332532

merged 1 commit into from
Dec 12, 2024

Conversation

paveloom
Copy link
Member

@paveloom paveloom commented Aug 5, 2024

Description of changes

https://eddie.website

Closes #73233.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Aug 5, 2024
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Aug 5, 2024
@h4rldev
Copy link

h4rldev commented Aug 17, 2024

+1

@FliegendeWurst FliegendeWurst added needs_merger (old Marvin label, do not use) 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 13, 2024
@paveloom paveloom changed the title eddie: init at 2.24.2 eddie: init at 2.24.4 Dec 6, 2024
@paveloom
Copy link
Member Author

paveloom commented Dec 6, 2024

The msbuild package currently uses dotnetCorePackages.sdk_6_0 that has been recently marked as insecure.

@FliegendeWurst
Copy link
Member

Tracking issue for .NET 6/7: #326335

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 6, 2024
@FliegendeWurst FliegendeWurst removed the needs_merger (old Marvin label, do not use) label Dec 8, 2024
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package LGTM. But I'd prefer to see the msbuild situation resolved (as in, a WIP PR for updating msbuild) before merging. No point in having this package if the build tool will be removed soon-ish.

@FliegendeWurst FliegendeWurst merged commit e6a99ff into NixOS:master Dec 12, 2024
43 of 44 checks passed
@paveloom paveloom deleted the eddie branch December 14, 2024 10:12
@yuannan
Copy link

yuannan commented Dec 15, 2024

I'm having to add dot net runtime 6 to the EOL list in order to install this. Is this due to eddie?

The only difference in getting this error or not is from eddie. I've tried it with my flake.nix as well as nix-shell.

@FliegendeWurst
Copy link
Member

Yes, it depends on msbuild, which depends on .NET 6, which is marked insecure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packaging requests: eddie-ui
5 participants