Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kanidm: require big-parallel for building #338001

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

adamcstephens
Copy link
Contributor

Description of changes

Build has timed out and been killed multiple times on hydra builds. This forces users to attempt to build it themselves, which they cannot due without sufficient resources.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from erictapen and Flakebi August 28, 2024 19:57
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Aug 28, 2024
Copy link
Member

@Flakebi Flakebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me

pkgs/by-name/ka/kanidm/package.nix Outdated Show resolved Hide resolved
Build has timed out and been killed multiple times on hydra builds. This forces users to attempt to build it themselves, which they cannot due without sufficient resources.
@adamcstephens adamcstephens merged commit 93c7d75 into NixOS:master Aug 28, 2024
8 of 9 checks passed
@adamcstephens adamcstephens deleted the kanidm/bigparallel branch August 28, 2024 21:57
Copy link
Contributor

Successfully created backport PR for release-24.05:

@adamcstephens
Copy link
Contributor Author

Thanks, I agree we definitely want this backported.

@erictapen
Copy link
Member

A bit offtopic, but how would somebody apply for job restart privileges on hydra.nixos.org? I noticed the build failure early and would be available in the future to restart the job.

@adamcstephens
Copy link
Contributor Author

I'm not sure the official process. I asked in the matrix infra room and was given the permission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants