nixos/services.factorio: fix escapeShellArg

[Stunkymonkey]

Description of changes

follow-up #338052

ping @Daholli

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[Daholli]

I will test it after work today! Thanks for the quick reaction

[Daholli]

nix-shell -p nixpkgs-review --run "nixpkgs-review pr https://github.com/NixOS/nixpkgs/pull/339115"

when I try to run this it only builds disko, might have to do with it being a draft, but i assume that this should be the fix regardless

[philiptaron]

nix-shell -p nixpkgs-review --run "nixpkgs-review pr https://github.com/NixOS/nixpkgs/pull/339115"

when I try to run this it only builds disko, might have to do with it being a draft, but i assume that this should be the fix regardless

This is a NixOS module, not a package, so that's expected. disko builds because it takes a dependency on everything in nixos (indirectly, through nixos-install-tools)

[Daholli]

ohhhhh! sorry :D I am still fairly new in the ecosystem. That does make some sense then, is there a way to make sure it would buld in a derivation?

I guess i could change the flake input to point to his repo and check it that way?

[philiptaron]

I guess i could change the flake input to point to his repo and check it that way?

Yep!

[Daholli]

yup that works!