Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL_compat: rework #339116

Closed
wants to merge 10 commits into from
Closed

Conversation

AndersonTorres
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@AndersonTorres AndersonTorres marked this pull request as ready for review September 2, 2024 21:56
@AndersonTorres AndersonTorres marked this pull request as draft September 2, 2024 21:56
@AndersonTorres AndersonTorres force-pushed the upload-sdl-compat-staging branch from eb60549 to 92453fc Compare September 2, 2024 22:04
@AndersonTorres AndersonTorres force-pushed the upload-sdl-compat-staging branch from 92453fc to a31b65c Compare September 2, 2024 22:10
@AndersonTorres AndersonTorres marked this pull request as ready for review September 2, 2024 23:39
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Sep 2, 2024
@ofborg ofborg bot requested review from peterhoeg and lovek323 September 3, 2024 00:00
@AndersonTorres
Copy link
Member Author

Only 100? I will close and send it to Master!

@AndersonTorres AndersonTorres deleted the upload-sdl-compat-staging branch September 3, 2024 16:57
@peterhoeg
Copy link
Member

Just FYI, you don't need to close and open a new PR if you want to target a different branch. You can just hit the "Edit" button at the top right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants