🏡 Home Assistant Refresh #340251
Draft
🏡 Home Assistant Refresh #340251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sending SIGHUP to hass it will exit with code 100, which is the codified exit code to trigger a restart. This is useful, because it can allow triggering a restart from within the frontend. It was previously assumed that it would result in a reload, which would keep the same interpreter process intact. That is not the case and so the assumption that the PID would stay the same was flawed and only succeeded due to race conditions.
github-actions
bot
added
6.topic: nixos
mweinelt
force-pushed
the
home-assistant-refresh
branch
from
b59fe97 to
7593efc
Compare
The backup module is part of the default integrations and as such it will always be loaded. Replace it with the prometheus module, for which this is probably unlikely to ever become the case.
In particular replace propagatedBuildInputs with dependencies.
…alling Kill the tedious work of setting up attributes manually.
mweinelt
force-pushed
the
home-assistant-refresh
branch
from
7593efc to
02cc60e
Compare
ofborg
bot
added
10.rebuild-darwin: 0
|
I was going to open a new PR for this: kira-bruneau@c0ed7c1, but I noticed that this refresh PR was just opened. Would it be ok to include those changes here? |
|
Oh wait nvm, I thought this touched the package, I'll just open a new PR: #340324 |
wegank
added
the
2.status: merge conflict
Comment on lines
+711
to
+714
| ExecReload = (escapeSystemdExecArgs [ | ||
| (lib.getExe' pkgs.coreutils "kill") | ||
| "-HUP" | ||
| ]) + " $MAINPID"; |
There was a problem hiding this comment.
The escapeSystemdExecArgs is superfluous here as the input is not user controlled and will never escape something.
| @@ -398,7 +406,7 @@ in { | |||
| themes = "!include_dir_merge_named themes"; | |||
| }; | |||
| http = {}; | |||
| feedreader.urls = [ "https://nixos.org/blogs.xml" ]; | |||
There was a problem hiding this comment.
FYI the new URL would be https://nixos.org/blog/feed.xml
There was a problem hiding this comment.
It's an example, and I think pointing to the nix tag at lobsters is much more interesting than the announcements on the homepage.
h7x4
reviewed
Sep 30, 2024
| @@ -11,7 +44,7 @@ let | |||
| # options shown in settings. | |||
| # We post-process the result to add support for YAML functions, like secrets or includes, see e.g. | |||
| # https://www.home-assistant.io/docs/configuration/secrets/ | |||
| filteredConfig = lib.converge (lib.filterAttrsRecursive (_: v: ! elem v [ null ])) (lib.recursiveUpdate customLovelaceModulesResources (cfg.config or {})); | |||
| filteredConfig = converge (filterAttrsRecursive (_: v: ! elem v [ null ])) (recursiveUpdate lovelaceResourceConfig (cfg.config or {})); | |||
There was a problem hiding this comment.
Suggested change
| filteredConfig = converge (filterAttrsRecursive (_: v: ! elem v [ null ])) (recursiveUpdate lovelaceResourceConfig (cfg.config or {})); | |
| filteredConfig = converge (filterAttrsRecursive (_: v: v != null)) (recursiveUpdate lovelaceResourceConfig (cfg.config or {})); |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Resolve a bunch of maintenance tasks:
with libextraArgsto the command linecustomoption prefixes (e.g. fromcustomLovelaceModules) and make options names more concreterunTestinstead ofhandleTestThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.