openutau: bump dotnet version 7 -> 8 #340611
Conversation
| substituteInPlace OpenUtau/OpenUtau.csproj OpenUtau.Test/OpenUtau.Test.csproj --replace \ | ||
| '<TargetFramework>net6.0</TargetFramework>' \ | ||
| '<TargetFramework>net7.0</TargetFramework>' | ||
| '<TargetFramework>net8.0</TargetFramework>' |
There was a problem hiding this comment.
Is there a reason why we're patching this? .NET 6 is an LTS release and isn't EOL yet.
There was a problem hiding this comment.
.NET 6 just went EOL as of Nov. 12. As of now, the defaults for dotnet-sdk and dotnet-runtime still point to .NET 6, but this will likely change soon. I have no idea how long it will take for upstream to update to .NET 8. I would say that the patch is appropriate in this case, but I'm open to further discussion.
There was a problem hiding this comment.
The upstream maintainer made a PR that updates to .NET 8: stakira/OpenUtau#1331.
| dotnet-sdk = dotnetCorePackages.sdk_8_0; | ||
| dotnet-runtime = dotnetCorePackages.runtime_8_0; |
There was a problem hiding this comment.
If you drop the patch below, you can remove this as dotnet-sdk and dotnet-runtime are set to .NET 6 in buildDotnetModule by default.
wegank
added
the
12.approvals: 1
There was a problem hiding this comment.
Thanks, LGTM
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 340611
x86_64-linux
✅ 1 package built:
- openutau
gepbird
added
12.approvals: 2
|
Successfully created backport PR for |
Description of changes
Upgraded dotnet version because it was causing issues in the newest release (stakira/OpenUtau#1233, stakira/OpenUtau#1270). Dotnet 7 is also EOL (#326335), so moving to the latest LTS release makes sense.
I have also removed the unfree license because worldline is now open source.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.