Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

writers: disable broken test (fsharp) #343507

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

jlesquembre
Copy link
Member

Description of changes

As noticed in #335969, tests.writers.simple.fsharp is currently broken on master. I tried to fix it, but unfortunately, I am unfamiliar with F#.

If no one can provide a solution, I propose commenting out the test to prevent it from blocking further development of the writers.

Hydra logs: https://hydra.nixos.org/build/272877892

cc @moinessim @raphaelr, since they worked on the F# writer

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 21, 2024
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also have no idea how to properly fix it

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 22, 2024
@jlesquembre
Copy link
Member Author

I noticed the error while working on #343510

@jlesquembre
Copy link
Member Author

@Lassulus Is there anything I can do to move this PR, and hopefully #343510 as well, forward?

@Lassulus Lassulus merged commit a6521dc into NixOS:master Oct 4, 2024
25 checks passed
@jlesquembre jlesquembre deleted the jl/fsharp-write branch October 6, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants