Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtatsu: init, libimobiledevice-drvs: update all with minor rebuilds #349567

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Frontear
Copy link
Member

@Frontear Frontear commented Oct 18, 2024

This is a separation commit from #342961 targetting all derivations that result in minor rebuilds. The maximum rebuilds I have observed from these are 33.

These changes were accompanied by cleanup that is shared between both PRs. Cleanup includes:

  • Adding unstableGitUpdater to all derivations (see explanation by @restoration578 here)
  • Marking meta.license more consistently to upstream
  • Using the GitHub repo as meta.homepage
  • Using platforms.unix for all derivations in meta.platforms
  • Moving all packages to pkgs/by-name
  • Adding myself as maintainer

cc @restoration578 @clebs @RossComputerGuy @winterqt as commentors from the previous pr.

Relevant Issues

Closes #342738
Closes #342736
Closes #342731
Closes #342728
Closes #342729

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Frontear
Copy link
Member Author

Drafting to perform a minor version bump on all of these derivations, including rebasing to the current master

@Frontear Frontear force-pushed the init-libtatsu-and-update-minor-libimobiledevice-drvs branch from 205c16e to 78011da Compare October 18, 2024 16:30
@Frontear Frontear marked this pull request as ready for review October 18, 2024 16:30
@Frontear
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 349567


x86_64-linux

✅ 10 packages built:
  • ideviceinstaller
  • idevicerestore
  • ifuse
  • libideviceactivation
  • libirecovery
  • libirecovery.dev
  • libtatsu
  • rapid-photo-downloader
  • rapid-photo-downloader.dist
  • usbmuxd

@Frontear Frontear force-pushed the init-libtatsu-and-update-minor-libimobiledevice-drvs branch from 78011da to 4639e34 Compare October 18, 2024 17:47
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Oct 18, 2024
@ofborg ofborg bot requested review from aristidb, nh2 and clebs October 18, 2024 20:42
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 18, 2024
Copy link
Member

@clebs clebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on libdeviceactivation

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Oct 22, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 10, 2024
@wegank wegank removed the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
4 participants