-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libtatsu: init, libimobiledevice-drvs: update all with minor rebuilds #349567
Open
Frontear
wants to merge
12
commits into
NixOS:master
Choose a base branch
from
Frontear:init-libtatsu-and-update-minor-libimobiledevice-drvs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
libtatsu: init, libimobiledevice-drvs: update all with minor rebuilds #349567
Frontear
wants to merge
12
commits into
NixOS:master
from
Frontear:init-libtatsu-and-update-minor-libimobiledevice-drvs
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drafting to perform a minor version bump on all of these derivations, including rebasing to the current master |
13 tasks
Frontear
force-pushed
the
init-libtatsu-and-update-minor-libimobiledevice-drvs
branch
from
October 18, 2024 16:30
205c16e
to
78011da
Compare
|
Frontear
force-pushed
the
init-libtatsu-and-update-minor-libimobiledevice-drvs
branch
from
October 18, 2024 17:47
78011da
to
4639e34
Compare
ofborg
bot
added
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
Oct 18, 2024
clebs
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on libdeviceactivation
wegank
added
12.approvals: 1
This PR was reviewed and approved by one reputable person
12.approved-by: package-maintainer
This PR was reviewed and approved by a maintainer listed in the package
labels
Oct 22, 2024
wegank
added
the
2.status: merge conflict
This PR has merge conflicts with the target branch
label
Nov 10, 2024
wegank
removed
the
12.approved-by: package-maintainer
This PR was reviewed and approved by a maintainer listed in the package
label
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.status: merge conflict
This PR has merge conflicts with the target branch
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
12.approvals: 1
This PR was reviewed and approved by one reputable person
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a separation commit from #342961 targetting all derivations that result in minor rebuilds. The maximum rebuilds I have observed from these are 33.
These changes were accompanied by cleanup that is shared between both PRs. Cleanup includes:
unstableGitUpdater
to all derivations (see explanation by @restoration578 here)meta.license
more consistently to upstreammeta.homepage
platforms.unix
for all derivations inmeta.platforms
pkgs/by-name
cc @restoration578 @clebs @RossComputerGuy @winterqt as commentors from the previous pr.
Relevant Issues
Closes #342738
Closes #342736
Closes #342731
Closes #342728
Closes #342729
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.