-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emacsPackages: clean the bulk-updating scripts #351056
Draft
AndersonTorres
wants to merge
6
commits into
NixOS:master
Choose a base branch
from
museoa:elisp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: clean-up
8.has: package (new)
This PR adds a new package
labels
Oct 25, 2024
jian-lin
requested changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding documentation is always good.
Please remove those commits updating elisp packages.
pkgs/applications/editors/emacs/elisp-packages/lib-update-scripts.sh
Outdated
Show resolved
Hide resolved
pkgs/applications/editors/emacs/elisp-packages/lib-update-scripts.sh
Outdated
Show resolved
Hide resolved
pkgs/applications/editors/emacs/elisp-packages/elpa-devel-generated.nix
Outdated
Show resolved
Hide resolved
AndersonTorres
force-pushed
the
elisp
branch
5 times, most recently
from
October 26, 2024 01:24
9cae614
to
af1a662
Compare
ofborg
bot
added
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 0
This PR does not cause any packages to rebuild on Linux
and removed
10.rebuild-darwin: 501+
10.rebuild-darwin: 1001-2500
10.rebuild-linux: 501+
10.rebuild-linux: 1001-2500
labels
Oct 26, 2024
AndersonTorres
force-pushed
the
elisp
branch
7 times, most recently
from
October 26, 2024 17:19
e110470
to
6539e9f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ofborg
bot
added
10.rebuild-linux: 0
This PR does not cause any packages to rebuild on Linux
and removed
10.rebuild-linux: 1
10.rebuild-linux: 1-10
labels
Nov 1, 2024
AndersonTorres
force-pushed
the
elisp
branch
from
November 16, 2024 20:51
d755534
to
fabe1cc
Compare
github-actions
bot
added
the
8.has: documentation
This PR adds or changes documentation
label
Dec 6, 2024
13 tasks
Drafted |
github-actions
bot
added
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
and removed
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 0
This PR does not cause any packages to rebuild on Linux
labels
Dec 6, 2024
AndersonTorres
force-pushed
the
elisp
branch
2 times, most recently
from
December 14, 2024 17:45
a544d0c
to
538db05
Compare
AndersonTorres
force-pushed
the
elisp
branch
4 times, most recently
from
January 21, 2025 02:16
d783b45
to
09eaa68
Compare
The tasks executed by the update-from-overlay script are very useful for interactive as well as batch update sessions. Thinking about it, I refactored the whole thing: - The tasks are now functions kept in a file, `update-scripts-library.sh`. This file is meant to be sourced, so that the functions can be used in both batch and interactive environments. - The update-from-overlay script was rewritten accordingly. - Since Bash lacks serious data structures, I am using a JSON file as database.
They are identical except for the parameters they use. Let's merge them in a single script. Now they can be called via `./update-package-sets <package sets>`.
They will be gathered in a more fitting documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: emacs
Text editor
8.has: clean-up
8.has: documentation
This PR adds or changes documentation
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.