nixos/modules: Add security.pki.caBundle option and make all services use it for CA bundles #352244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
… use it for CA bundles
Previously some modules used `config.environment.etc."ssl/certs/ca-certificates.crt".source`, some used `"/etc/ssl/certs/ca-certificates.crt"`, and some used `"${pkgs.cacert}/etc/ssl/certs/ca-bundle.crt"`. These were all bad in one way or another:
- `config.environment.etc."ssl/certs/ca-certificates.crt".source` relies on `source` being set; if `text` is set instead this breaks, introducing a weird undocumented requirement
- `"/etc/ssl/certs/ca-certificates.crt"` is probably okay but very un-nix. It's a magic string, and the path doesn't change when the file changes (and so you can't trigger service reloads, for example, when the contents change in a new system activation)
- `"${pkgs.cacert}/etc/ssl/certs/ca-bundle.crt"` silently doesn't include the options from `security.pki`
shelvacu
force-pushed
the
unify-caBundle
branch
from
9c2e671 to
d37c608
Compare
|
@ofborg test gonic navidrome gocd-agent gocd-server postfix db-rest gitlab portunus radicle tandoor-recipes ocsinventory-agent parsedmarc uptime-kuma biboumi gateone privoxy stunnel unbound hound nix-daemon transmission cryptpad dex nextcloud peertube sogo |
|
I don't know what command to run to reproduce the ofborg/CI fail.
|
wegank
added
the
2.status: merge conflict
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4842 |
ofborg
bot
removed
the
2.status: merge conflict
shelvacu
force-pushed
the
unify-caBundle
branch
2 times, most recently
from
64b8011 to
484786a
Compare
shelvacu
force-pushed
the
unify-caBundle
branch
from
484786a to
af5fd5b
Compare
github-actions
bot
added
10.rebuild-darwin: 0
shelvacu
force-pushed
the
unify-caBundle
branch
from
af5fd5b to
d37c608
Compare
ofborg
bot
added
the
2.status: merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously some modules used
config.environment.etc."ssl/certs/ca-certificates.crt".source, some used"/etc/ssl/certs/ca-certificates.crt", and some used"${pkgs.cacert}/etc/ssl/certs/ca-bundle.crt". These were all bad in one way or another:config.environment.etc."ssl/certs/ca-certificates.crt".sourcerelies onsourcebeing set; iftextis set instead this breaks, introducing a weird undocumented requirement"/etc/ssl/certs/ca-certificates.crt"is probably okay but very un-nix. It's a magic string, and the path doesn't change when the file changes (and so you can't trigger service reloads, for example, when the contents change in a new system activation)"${pkgs.cacert}/etc/ssl/certs/ca-bundle.crt"silently doesn't include the options fromsecurity.pkiThings done
Add a 👍 reaction to pull requests you find important.