-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kanidm: add support for multiple versions #357734
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamcstephens
force-pushed
the
push-kupzsmomprsz
branch
from
November 21, 2024 01:36
1e6da73
to
1fc0666
Compare
This won’t meet the |
ofborg
bot
added
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
Nov 21, 2024
adamcstephens
force-pushed
the
push-kupzsmomprsz
branch
2 times, most recently
from
December 3, 2024 15:13
1ab3eef
to
3556a40
Compare
github-actions
bot
added
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: module (update)
This PR changes an existing module in `nixos/`
and removed
10.rebuild-linux: 1
labels
Dec 3, 2024
oddlama
reviewed
Dec 4, 2024
adamcstephens
force-pushed
the
push-kupzsmomprsz
branch
from
December 4, 2024 13:35
c4d13b4
to
efab2bb
Compare
oddlama
approved these changes
Dec 4, 2024
No rebuild changes for 1.4, and 1.3 is insecure as expected. aarch64-linux
|
Hi, do you have any update about the backport to 24.11? |
Yes, #364105 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: module (update)
This PR changes an existing module in `nixos/`
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds package support for multiple versions.
Will probably require updateScript modifictions, but putting that off for now.Sets default in module to the version at NixOS release time. kanidm will release new, potentially breaking changes during each NixOS release, at which point users will need to manually update their configuration.
This will be manually backported, with the stateVersion updated for 24.05, to verify the workflow and ensure support for the remaining weeks of 24.05.
Resolves #353889
Closes #361458
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.