lockbook: init at 0.9.15 #358794
Merged
lockbook: init at 0.9.15 #358794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NixOSInfra
added
the
12. first-time contribution
github-actions
bot
added
the
8.has: maintainer-list (update)
Parth
force-pushed
the
master
branch
3 times, most recently
from
40f8281 to
2cf3f39
Compare
smailbarkouch
approved these changes
Nov 24, 2024
ofborg
bot
added
8.has: package (new)
pluiedev
suggested changes
Nov 25, 2024
wegank
added
the
12.approvals: 1
Parth
force-pushed
the
master
branch
2 times, most recently
from
4e5a552 to
5a073b5
Compare
pluiedev
approved these changes
Nov 26, 2024
|
Thank you for the thoughtful feedback @donovanglover & @pluiedev! Could you guys have another look? I believe I addressed all your feedback (and learned a lot along the way). |
wegank
removed
the
12.approvals: 1
Aleksanaa
reviewed
Nov 29, 2024
pkgs/by-name/lo/lockbook/package.nix
Outdated
| ]; | ||
|
|
||
| nativeBuildInputs = [ installShellFiles ]; | ||
| postInstall = '' |
There was a problem hiding this comment.
Suggested change
| postInstall = '' | |
| postInstall = lib.optionalString (stdenv.buildPlatform.canExecute stdenv.hostPlatform) '' |
There was a problem hiding this comment.
Thank you, I fixed & force pushed
pkgs/by-name/lo/lockbook/package.nix
Outdated
| useFetchCargoVendor = true; | ||
| cargoHash = "sha256-+M+wL26KDbLKhcujPyWAsTlXwLrQVCUbTnnu/7sXul4="; | ||
|
|
||
| doCheck = false; |
There was a problem hiding this comment.
Reason
Suggested change
| doCheck = false; | |
| doCheck = false; # No checks defined |
Suggested change
| doCheck = false; | |
| doCheck = false; # Require network access |
Suggested change
| doCheck = false; | |
| doCheck = false; # Require instance of <specific service> |
There was a problem hiding this comment.
Thank you, I fixed & force pushed
pkgs/by-name/lo/lockbook/package.nix
Outdated
| meta = { | ||
| description = "Private, polished note-taking platform"; | ||
| longDescription = '' | ||
| Write notes, sketch ideas, and store files in one secure place. Share seamlessly, keep data synced, and access it on any platform—even offline. Lockbook encrypts files so even we can’t see them, but don’t take our word for it: Lockbook is 100% open-source. |
There was a problem hiding this comment.
Suggested change
| Write notes, sketch ideas, and store files in one secure place. Share seamlessly, keep data synced, and access it on any platform—even offline. Lockbook encrypts files so even we can’t see them, but don’t take our word for it: Lockbook is 100% open-source. | |
| Write notes, sketch ideas, and store files in one secure place. | |
| Share seamlessly, keep data synced, and access it on any | |
| platform—even offline. Lockbook encrypts files so even we | |
| can’t see them, but don’t take our word for it: Lockbook is | |
| 100% open-source. |
There was a problem hiding this comment.
Thank you, I fixed & force pushed
|
Thanks @Aleksanaa, @donovanglover I believe I addressed all your comments, could you take another pass when you have some time? Having some trouble understanding the permission hierarchy is there someone else I should be tagging for the final merge? |
|
@ofborg build lockbook |
13 tasks
Parth
added
backport staging-24.05
backport staging-24.11
This comment was marked as resolved.
This comment was marked as resolved.
|
Successfully created backport PR for |
1 task
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
Successfully created backport PR for |
1 task
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
Successfully created backport PR for |
This comment was marked as resolved.
This comment was marked as resolved.
1 task
This comment was marked as resolved.
This comment was marked as resolved.
1 similar comment
This comment was marked as resolved.
This comment was marked as resolved.
|
Successfully created backport PR for |
This comment was marked as resolved.
This comment was marked as resolved.
1 task
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Lockbook is an open source secure note taking app. This packages our CLI. Soon we'll have another pr for our desktop app.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.