Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.pytransportnswv2: fix build #359113

Merged
merged 1 commit into from
Nov 26, 2024
Merged

python312Packages.pytransportnswv2: fix build #359113

merged 1 commit into from
Nov 26, 2024

Conversation

wegank
Copy link
Member

@wegank wegank commented Nov 25, 2024 •
edited
Loading

ZHF: #352882

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fabaff
Copy link
Member

fabaff commented Nov 25, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 359113

x86_64-linux

✅ 4 packages built:
  • python311Packages.pytransportnswv2
  • python311Packages.pytransportnswv2.dist
  • python312Packages.pytransportnswv2
  • python312Packages.pytransportnswv2.dist

@ofborg ofborg bot requested a review from fabaff November 26, 2024 16:52
fabaff
fabaff approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit e605aab into NixOS:master Nov 26, 2024
49 of 51 checks passed
@wegank wegank deleted the pytransportnswv2-fix branch November 26, 2024 20:31
@vcunat vcunat added the backport release-24.11 Backport PR automatically label Dec 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2024

Successfully created backport PR for release-24.11:

@github-actions github-actions bot mentioned this pull request Dec 1, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wegank @fabaff @vcunat