Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.hcs-utils: fix build #359237

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

Bot-wxt1221
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 commented Nov 26, 2024

ZHF: #352882

Only source on gitlab have test.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Bot-wxt1221
Copy link
Member Author

@ofborg build python312Packages.hcs-utils python311Packages.hcs-utils

@fabaff
Copy link
Member

fabaff commented Nov 26, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 359237


x86_64-linux

✅ 4 packages built:
  • python311Packages.hcs-utils
  • python311Packages.hcs-utils.dist
  • python312Packages.hcs-utils
  • python312Packages.hcs-utils.dist

@Bot-wxt1221 Bot-wxt1221 requested a review from fabaff November 26, 2024 13:55
@Bot-wxt1221
Copy link
Member Author

@fabaff Done.

@Aleksanaa
Copy link
Member

@ofborg build python311Packages.hcs-utils python312Packages.hcs-utils

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 27, 2024
@ofborg ofborg bot requested a review from lovek323 November 27, 2024 22:20
@Bot-wxt1221
Copy link
Member Author

@ofborg build python311Packages.hcs-utils python312Packages.hcs-utils

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 8, 2024
@fabaff
Copy link
Member

fabaff commented Dec 20, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 359237


x86_64-linux

✅ 4 packages built:
  • python311Packages.hcs-utils
  • python311Packages.hcs-utils.dist
  • python312Packages.hcs-utils
  • python312Packages.hcs-utils.dist

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit dbbaf90 into NixOS:master Dec 20, 2024
39 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants