Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maturin: 1.7.4 -> 1.7.5 #359505

Merged
merged 1 commit into from
Dec 5, 2024
Merged

maturin: 1.7.4 -> 1.7.5 #359505

merged 1 commit into from
Dec 5, 2024

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Nov 27, 2024 •
edited
Loading

Changes:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from getchoo November 28, 2024 01:25
getchoo
getchoo approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebuilt uv on nixos-unstable

let
  overlay = final: _: { maturin = final.callPackage ./pkgs/by-name/ma/maturin/package.nix { }; };
  pkgs = import <nixpkgs> {
    system = builtins.currentSystem;
    config = { };
    overlays = [ overlay ];
  };
in
  pkgs.uv

@getchoo getchoo added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport staging-24.11 Backport PR automatically labels Nov 28, 2024
@trofi trofi changed the title maturin: 1.7.4 -> 1.7.5 maturin: 1.7.4 -> 1.7.6 Nov 29, 2024
@trofi trofi changed the title maturin: 1.7.4 -> 1.7.6 maturin: 1.7.4 -> 1.7.5 Nov 29, 2024
@trofi
Copy link
Contributor Author

trofi commented Nov 29, 2024

Rolled back to just 1.7.5 update.

1.7.6 breaks python3.12-word-count-0.13.2.drv as:

    | packaging.metadata.InvalidMetadata: '2.4' is not a valid metadata version

getchoo
getchoo approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carrying over my review

@ofborg ofborg bot requested a review from getchoo November 30, 2024 00:26
@getchoo
Copy link
Member

getchoo commented Dec 4, 2024

1.7.7 is out

@trofi
Copy link
Contributor Author

trofi commented Dec 5, 2024

Looks like 1.7.7 breaks just like 1.7.6 in #359505 (comment)

getchoo
getchoo approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully upstream will get these issues sorted out next release

@getchoo getchoo merged commit 477a7db into NixOS:staging Dec 5, 2024
76 of 77 checks passed
nixpkgs-ci bot pushed a commit that referenced this pull request Dec 5, 2024
@trofi @github-actions
maturin: 1.7.4 -> 1.7.5 (#359505)
6532676 
(cherry picked from commit 477a7db)
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 5, 2024

Successfully created backport PR for staging-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Dec 5, 2024
Merged
1 task
@trofi trofi deleted the maturin-update branch December 5, 2024 22:53
getchoo pushed a commit that referenced this pull request Dec 7, 2024
@nixpkgs-ci @trofi
[Backport staging-24.11] maturin: 1.7.4 -> 1.7.5 (#362203)
41c6bcf 
maturin: 1.7.4 -> 1.7.5 (#359505)

(cherry picked from commit 477a7db)

Co-authored-by: Sergei Trofimovich <[email protected]>
@getchoo getchoo mentioned this pull request Dec 9, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getchoo getchoo getchoo approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport staging-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trofi @getchoo