Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.django-rest-registration: fix build #359565

Merged
merged 1 commit into from
Nov 29, 2024
Merged

python312Packages.django-rest-registration: fix build #359565

merged 1 commit into from
Nov 29, 2024

Conversation

Bot-wxt1221
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 commented Nov 27, 2024 •
edited
Loading

ZHF: #352882

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Bot-wxt1221 Bot-wxt1221 requested review from fabaff and sephii and removed request for fabaff November 27, 2024 12:30
@Bot-wxt1221 Bot-wxt1221 force-pushed the django-rest-registration branch from 973c18c to 0419cb5 Compare November 28, 2024 08:38
@Bot-wxt1221 Bot-wxt1221 requested a review from sephii November 28, 2024 08:38
sephii
sephii approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@sephii sephii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 28, 2024
@ofborg ofborg bot requested a review from sephii November 29, 2024 00:10
@wegank wegank added the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package label Nov 29, 2024
@uninsane uninsane merged commit 55303d5 into NixOS:master Nov 29, 2024
35 of 36 checks passed
@Bot-wxt1221 Bot-wxt1221 added the backport release-24.11 Backport PR automatically label Dec 8, 2024
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 8, 2024

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Dec 8, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sephii sephii sephii approved these changes

@fabaff fabaff Awaiting requested review from fabaff

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bot-wxt1221 @sephii @wegank @uninsane