Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

omnisharp-roslyn: bump from .NET 6 to 8, add support for 9 #360598

Merged
merged 1 commit into from
Dec 1, 2024
Merged

omnisharp-roslyn: bump from .NET 6 to 8, add support for 9 #360598

merged 1 commit into from
Dec 1, 2024

Conversation

gepbird
Copy link
Contributor

@gepbird gepbird commented Nov 30, 2024 •
edited
Loading

Tracking: #326335

cc @emilazy (#358533)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@gepbird
Copy link
Contributor Author

gepbird commented Nov 30, 2024

(Sorry about the unrelated pings)

GGG-KILLER
GGG-KILLER approved these changes Nov 30, 2024
View reviewed changes
Copy link
Contributor

@GGG-KILLER GGG-KILLER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't run nixpkgs-review since I'm on my phone, but diff-wise it looks good.

@GGG-KILLER GGG-KILLER added 12.approvals: 1 This PR was reviewed and approved by one reputable person 6.topic: dotnet Language: .NET labels Nov 30, 2024
@gepbird gepbird mentioned this pull request Dec 1, 2024
Open
17 tasks
@gepbird
Copy link
Contributor Author

gepbird commented Dec 1, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 360598

x86_64-linux

✅ 1 package built:
  • omnisharp-roslyn

@github-actions github-actions bot removed the 6.topic: dotnet Language: .NET label Dec 1, 2024
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 360598

x86_64-linux

✅ 1 package built:
  • omnisharp-roslyn

aarch64-linux

✅ 1 package built:
  • omnisharp-roslyn

x86_64-darwin

✅ 1 package built:
  • omnisharp-roslyn

aarch64-darwin

✅ 1 package built:
  • omnisharp-roslyn

GaetanLepage
GaetanLepage approved these changes Dec 1, 2024
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GGG-KILLER GGG-KILLER added 12.approvals: 2 This PR was reviewed and approved by two reputable people awaiting_merger (old Marvin label, do not use) and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 1, 2024
@corngood corngood added the backport release-24.11 Backport PR automatically label Dec 1, 2024
@ofborg ofborg bot requested a review from corngood December 1, 2024 15:25
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 1, 2024
@wolfgangwalther wolfgangwalther merged commit 7d0c560 into NixOS:master Dec 1, 2024
45 of 46 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2024

Successfully created backport PR for release-24.11:

@github-actions github-actions bot mentioned this pull request Dec 1, 2024
Merged
1 task
@gepbird gepbird deleted the omnisharp-dotnet-8 branch December 1, 2024 20:10
@UlyssesZh UlyssesZh mentioned this pull request Dec 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@GGG-KILLER GGG-KILLER GGG-KILLER approved these changes

@ericdallo ericdallo Awaiting requested review from ericdallo

@mdarocha mdarocha Awaiting requested review from mdarocha

@emilazy emilazy Awaiting requested review from emilazy

@corngood corngood Awaiting requested review from corngood

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people awaiting_merger (old Marvin label, do not use) backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gepbird @GaetanLepage @corngood @GGG-KILLER @wolfgangwalther